Skip to content

feat: add streaming methods for elicitation and sampling #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
LucaButBoring wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: add streaming methods for elicitation and sampling #1210

LucaButBoring wants to merge 8 commits into from
+881 −12

Conversation

@LucaButBoring
Copy link
Contributor

@LucaButBoring LucaButBoring commented Dec 1, 2025 •
edited
Loading

Following #1041, this adds streaming methods for elicitation and sampling to simplify usage with Tasks.

Motivation and Context

Introduces a consistent way to use Tasks with elicitation and sampling just like we have with tool calls.

How Has This Been Tested?

New unit tests and example tool.

Breaking Changes

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 1, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/client@1210

npm i https://pkg.pr.new/modelcontextprotocol/typescript-sdk/@modelcontextprotocol/server@1210

commit: 9943196

@LucaButBoring LucaButBoring force-pushed the feat/elicitation-sampling-streaming branch 3 times, most recently from f8755d8 to 7520307 Compare December 1, 2025 23:52
@LucaButBoring LucaButBoring force-pushed the feat/elicitation-sampling-streaming branch from 7520307 to 4ed61b6 Compare December 1, 2025 23:58
@LucaButBoring LucaButBoring marked this pull request as ready for review December 2, 2025 00:04
@LucaButBoring LucaButBoring requested a review from a team as a code owner December 2, 2025 00:04
@LucaButBoring LucaButBoring marked this pull request as draft December 2, 2025 00:20
@LucaButBoring
Copy link
Contributor Author

LucaButBoring commented Dec 2, 2025

Doing some manual testing on this, converted back to draft temporarily

@LucaButBoring LucaButBoring marked this pull request as ready for review December 2, 2025 00:39
@LucaButBoring
Copy link
Contributor Author

LucaButBoring commented Dec 2, 2025

Validated with new example tool.

@LucaButBoring LucaButBoring force-pushed the feat/elicitation-sampling-streaming branch from ba50e0a to 771f101 Compare December 8, 2025 23:21
@felixweinberger felixweinberger self-requested a review December 9, 2025 14:53
@changeset-bot
Copy link

changeset-bot bot commented Dec 22, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9943196

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felixweinberger felixweinberger Awaiting requested review from felixweinberger

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@LucaButBoring